Ticket #7655 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Speed up CorrectFlightPaths unit test

Reported by: Russell Taylor Owned by: Ricardo Leal
Priority: critical Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: #7521 Tester: Russell Taylor

Description

This test has been shown to be one of our slowest unit tests; indeed on OS X it has been observed to take well over a minute! This needs to be improved to ideally ~1s but at least 3-4s across all platforms.

The first task is to refactor to not load a data file and use in-memory constructed test data instead. Just this step may well solve the speed problem on its own.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Keywords Maintenance added

comment:2 Changed 7 years ago by Ricardo Leal

  • Status changed from new to inprogress

Replaced loaded file by createProcessedInelasticWS Re #7655

Changeset: c2eea45c2f85df972d973706a139f0a6c6d3ba74

comment:3 Changed 7 years ago by Ricardo Leal

Timewise looks OK now: 

[ferrazpc 53] Build > ctest --output-on-failure  -R AlgorithmsTest_CorrectFlightPathsTest
Test project /home/leal/git/Mantid/Build
    Start 545: AlgorithmsTest_CorrectFlightPathsTest
1/1 Test #545: AlgorithmsTest_CorrectFlightPathsTest ...   Passed    0.13 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.17 sec

comment:4 Changed 7 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/7655_Speedup_CorrectFlightPaths'

comment:7 Changed 7 years ago by Russell Taylor

Great! In some cases the test went from taking minutes to milliseconds!

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8500

Note: See TracTickets for help on using tickets.