Ticket #766 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Allow LoadISISNexus load missing monitors

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Iteration 18
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Ross Whitfield

Description


Change History

comment:1 Changed 11 years ago by Roman Tolchenov

(In [2826]) Created version 2 of LoadISISNexus. re #766

comment:2 Changed 11 years ago by Roman Tolchenov

(In [2834]) A bug fix. re #766

comment:3 Changed 11 years ago by Roman Tolchenov

  • Status changed from new to closed
  • Resolution set to fixed

comment:4 Changed 5 years ago by Pete Peterson

Re #766. Exposing shared_ptr<Quat> and vector<Quat> in python.

Changeset: fb06545972f316dd3265889a3b9bbca1a230697f

comment:5 Changed 5 years ago by Pete Peterson

The pylint errors are not my fault. Something bad got into master.

comment:6 Changed 5 years ago by Pete Peterson

Refs #766. Exposing vector<V3D> to python.

Changeset: 9534577b7d80cc29c851d49bee9a92b609833b2c

comment:7 Changed 5 years ago by Federico Montesino Pouzols

A while ago I merged a branch that unfortunately came with a few pylint warnings. But those are not the ones that pylint is complaining about as new in this PR. The new ones here seem to come from various fronts (refl, eqsans, hfir, diffraction). I saw a similar thing in another PR before and I'm wondering where does that come from. Is Pylint supposed to take master as reference to calculate the +'s and -'s?

comment:8 Changed 5 years ago by Ross Whitfield

@FedeMPouzols The Pylint warning threshold is manually set to the same as master but when Pylint warnings are reduced but threshold is not, it allows new warnings to be added.

comment:9 Changed 5 years ago by Pete Peterson

The deltas are compared to the last (incremental) PR build. The fail is based on the hand set threshold.

comment:10 Changed 5 years ago by Ross Whitfield

  • Tester set to Ross Whitfield

Merge pull request #772 from mantidproject/766/Quat_in_python

Exposing shared_ptr<Quat> and vector<Quat> in python.

Full changeset: 118baa15bc5d4db3cf54caddb0a8e1bb2dfcabd9

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1614

Note: See TracTickets for help on using tickets.