Ticket #7660 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] Elwin: Replace python code with our own Logarithm algorithm

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Gesner Passos

Description

Elwin has it's own version of Logarithm. Change this to use the Mantid algorithm called Logarithm.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Swapped out python code for Mantid's Log algorithm.

Refs #7660

Changeset: 9071e4aab464699bdadec646b73e3e5112bd7452

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

Run Elwin as normal before starting the test (e.g. use instructions found here http://www.mantidproject.org/Indirect:Indirect_Data_Analysis). Then start the test and run it again and check the output is the same.

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Changing reference results.

Refs #7660

Changeset: a6cbf8f292a7b2d8bfdcf6639220b25b8ddfb516

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This broke a couple of systems tests as results were slightly different between python and C++ versions of the algorithm. The following tests were broken and have now been fixed:

SystemTests.ISISIndirectInelastic.IRISElwinAndMSDFit

SystemTests.ISISIndirectInelastic.OSIRISElwinAndMSDFit

Therefore when testing this be sure to merge both the branch and the system tests branch into master.

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.0

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:8 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7660_replace_py_with_log_alg'

comment:9 Changed 7 years ago by Gesner Passos

Merge remote-tracking branch 'origin/feature/7660_replace_py_with_log_alg'

comment:10 Changed 7 years ago by Gesner Passos

not it uses the algorithm Logarithm as it should, which is good. It does changes the results, but a small change. Assuming that is is better to use the Logarithm implemented in Mantid, it is aceptable to adjust the system tests data.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8505

Note: See TracTickets for help on using tickets.