Ticket #7662 (closed: fixed)
Migrate to new API scripts qtigenie
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | alex.buts@… | Blocked By: | |
| Blocking: | #7516, #7663 | Tester: | Alex Buts |
Description
Migrate to the new api the scripts inside: https://github.com/mantidproject/scripts/tree/master/inelastic/direct_geometry/qtiGenie
Change History
comment:3 Changed 7 years ago by Gesner Passos
https://github.com/mantidproject/scripts/commit/8b26f583aed302880d0b44a86925535455bd0857
Migrate qtiGenie.py to new api
https://github.com/mantidproject/scripts/commit/6fb7c5a8fe06031d4d61bc4e6b2bd9eb93b3aac9
migrate dgreduce_old to new api
https://github.com/mantidproject/scripts/commit/2ebd48db1500ce24cfb8e71561df934ef624fdbb
Migrate c2te algorithm to new api
https://github.com/mantidproject/scripts/commit/c4c924eacbde85efea5fda4973a74777e8a94ab5
Migrate PysliceGui to new api
https://github.com/mantidproject/scripts/commit/a0aec87f08e1eb86e7a11ccbb41c6215974f6a5f
Migrate PySlice2.py to new api
https://github.com/mantidproject/scripts/commit/1321c4fb791489bc41458ab44e541a2cc8438670
Upgrade PySlice.py to new api
comment:4 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
Probably the best person to test will be Alex who is working in these scripts.
comment:5 Changed 7 years ago by Alex Buts
- Status changed from verify to verifying
- Tester set to Alex Buts
comment:6 Changed 7 years ago by Alex Buts
- Status changed from verifying to closed
as I understand, the changes done on Master.
everything looks fine to me though checking everything properly would need bunch of unit tests which is a rather different story.
And the interface itself needs some efforts to improve but this is not the purpose of this ticket.
