Ticket #7665 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Migrate ConjoinSpectraNumAx.py to new API

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.0
Component: Python Keywords: ScriptRepository
Cc: Blocked By:
Blocking: #7516 Tester: Russell Taylor

Description

Hi James,

We are migrating the users scripts inside ScriptRepository to the new API.

You have uploaded one script called ConjoinSpectraNumAx.py inside general/Transforms/Merging which is an algorithm.

I've attached the same algorithm migrated to the new API. Could you please test it and ensure you are able to get the same results as you had in your previous algorithm.

Then, you may upload yourself the new version or just reply me if everything is ok and I will upload it for you.

Attachments

ConjoinSpectraNumAx.py​ (5.4 KB) - added by Gesner Passos 7 years ago.

Change History

Changed 7 years ago by Gesner Passos

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

This ​commit migrates to the new API.

comment:3 Changed 7 years ago by Gesner Passos

Tester:

Here, I would like you to review the code and check if the migration was correctly and sensible.

comment:4 Changed 7 years ago by Gesner Passos

  • Component changed from User Interface to Python API

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

The changes look correct and the algorithm can be run to completion successfully. Whether it does the right thing is up to the scientist to verify.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8510

Note: See TracTickets for help on using tickets.