Ticket #7669 (closed)
[IDA] Remove plot input buttons
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Gesner Passos |
Description
The Indirect Data Analysis interface has a number of "plot input" buttons that requires you to select a file, then click plot input to display the graph.
It would be better if the default behaviour was to simply plot the graph when the file is selected rather than having the user click a button every time.
There are also a couple of similar buttons on the C2E calibration and diagnostics tabs.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Updated IDA interface to auto plot files.
Refs #7669
Changeset: 556b1a54c8ee59f22960f0618c5a3efd5fa0dd4c
comment:3 Changed 7 years ago by Samuel Jackson
Updated C2E calib and diagnostics tabs to auto load.
Refs #7669
Changeset: f5a707471d9fc5185ed7f9db3629a90b73152914
comment:5 Changed 7 years ago by Samuel Jackson
To Test:
Both the IDA tabs and C2E calibration and diagnostics tabs have been updated to auto plot input where possible. Check that each of the tabs in the IDA interface (except calculate and apply corrections) and the C2E calibration and diagnostics tabs perform as normal, but that they also plot data automatically either when selecting a file using the file browser or by selecting an already loaded nexus file.
comment:6 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 7 years ago by Gesner Passos
- Status changed from verify to reopened
- Resolution fixed deleted
- Open Indirect Data Analysis
- Change to ConvFit tab
- Select the file: systemtests/Data/osi97936_graphite002_red.nxs
- It raises a warning: Selected input files are invalid
- But it plots the input, and if I select another file and them this file again, it won't show the warning any more.
comment:8 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Fix to stop showing error on first load in ConvFit.
Refs #7669
Changeset: e36c736e9b15f70ed25eb901b60abcf89e0fe0e7
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:11 Changed 7 years ago by Gesner Passos
- Status changed from verifying to reopened
- Resolution fixed deleted
I suggest catching the exception when trying to load an invalid file.
comment:12 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
More consistent error checking across tabs.
Refs #7669
Changeset: 4fb59b3c3e511fda1d6944ebff0d3bfe20c215e2
comment:13 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to closed
Merge remote-tracking branch 'origin/feature/7669_remove_plot_input_btns'
comment:14 Changed 7 years ago by Gesner Passos
It now has a consistent answer through the tabs, and the plot is updated as soon as possible just after loading the proper data.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8514
Buttons will not be completely removed as users may want to manually enter a file name into the file selector. Buttons will be removed in the case of workspace selectors and file selectors will still automatically plot input if possible.