Ticket #7673 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

CreateGroupingWorkspace should error if no groups are created

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

For last cycle powgen files there is no information in the geometry for "columns" and the algorithm creates a workspace without grouping information. The algorithm should generate an error if this is the case.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Peter Peterson

Re #7673. Added output properties...

...for the number of spectra in groups and the number of groups.

Changeset: 68950aa44cb9dc6afc6de31dd48015ac5dd5516f

comment:3 Changed 7 years ago by Peter Peterson

Re #7673. Throw error if no groups in CalibrateRectangularDetectors

Changeset: 37150d1339a39e6d86a96cc2209d6784811dedd3

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is in ​feature/7673_lack_of_groups.

To test:

  • Run CalibrateRectangularDetectors with PG3_13428 and GroupDetectorsBy=Column (which doesn't exist for that run). It should throw an exception.
  • Run CalibrateRectangularDetectors with PG3_13428 and GroupDetectorsBy=All. It should work as before.

comment:5 Changed 7 years ago by Peter Peterson

Re #7673. Fixing performance tests.

Changeset: 2bdb18beabcc3258e20a7549652fcb3af68fdf2a

comment:6 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:7 Changed 7 years ago by Michael Reuter

It looks like this is working as expected.

comment:8 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7673_lack_of_groups'

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8518

Note: See TracTickets for help on using tickets.