Illegal dependency in PeaksWorkspaceTest

[Russell Taylor]

PeaksWorkspaceTest, in the DataObjects package, implicitly depends on the 'higher' DataHandling package because it uses LoadEmptyInstrument, LoadNexus & SaveNexus. See http://www.mantidproject.org/Mantid_Package_Diagram for the package levels (the arrows are not quite accurate but the package levels are).

The test_Save_Unmodified_PeaksWorkspace_Nexus() method should move to the SaveNexus algorithm's test or should just operate on the PeaksWorkspace::saveNexus() method.

The test_createDetectorTable_With_Many_Peaks_And_Multiple_Dets() method should use an in-memory instrument instead.

[Karl Palmen]

I see it would be a good idea to move createSaveTestPeaksWorkspace() to WorkspaceCreationHelper to make to available to the moved test_Save_Unmodified_PeaksWorkspace_Nexus() and any other test that may use a peaks workspace. It loads its instrument from an IDF file rather than use an in mememory instrument.

[Russell Taylor]

No, that wouldn't be OK because WorkspaceCreationHelper may not use any package above DataObjects (i.e. no algorithms). I think the 'createDetectorTable' test ought to be able to use one of the existing WorkspaceCreationHelper methods and I've given 2 possible solutions for the other affected test (& I think I prefer the latter: test PeaksWorkspace::saveNexus directly)

[Karl Palmen]

Non working first step re #7674

Do not git checkbuild.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 236cda02a12240eb29cf2dd5f54ff0da675d1f18

[Karl Palmen]

Eliminate call of SaveNexus and LoadNexus algorithms re #7674

Now just tests saved file has 'peak_workspace' entry. Other tests for its contents to follow.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 17e951ace5010d9f55dc0cfb4d8c638b2c222b4b

[Karl Palmen]

Add check of detector IDs re #7674

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a65d9e0bd61addff08d8527cc9f834d7db7a7e82

[Karl Palmen]

Add check of wavelengths re #7674

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9c5c595d6c49149f00452c58ffee771634cf13d9

[Karl Palmen]

Tidy code for PeaksWorkspaceTest.h re #7674

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7f3178dece45ca7a4e32b91729b06783802e4317

[Karl Palmen]

Get createSaveTestPeaksWorkspace to use buildPW re #7674

I found out that workspace and instrument created by buildPW was adequate for my testing requirements.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3910f9e194702b0f977d981e5b5f3bfee86abe25

[Karl Palmen]

Improve comment of BuildPW re #7674

The comment now indicates that the workspace has one peak. This peak delayed work till I was aware of it.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9390880ea0176a5c6976f24337d77db3e0961c43

[Karl Palmen]

To test, review the code check that it no longer has the illegal dependencies, but still performs the tests.

[Russell Taylor]

Good - it's now possible to build only up to DataObjects and for the DataObjects unit test package to run successfully.

[Stuart Campbell]

This ticket has been transferred to github issue ​8519