Ticket #7679 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Reduce compiler warnings to zero

Reported by: Nick Draper Owned by: Peter Peterson
Priority: critical Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Pete,

Could you take a look at the warnings and either just fix or chase those responsible.

Owen would normally pick this up but he's taking a holiday for the next coule of weeks.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #7679. Adding macros for turning off compiler warnings.

Changeset: 9c48f0b07829c437d690886786e48ac35bacc36a

comment:2 Changed 7 years ago by Peter Peterson

Re #7679. Got rid of gcc compiler warnings.

Changeset: 23bc8d51fd89d2eb3d9e102735c026fbc40421a6

comment:3 Changed 7 years ago by Peter Peterson

Re #7679. Throwing in some cppcheck errors for giggles.

Changeset: 663ce30c95bc818ee3dff5775798bda155329e51

comment:4 Changed 7 years ago by Peter Peterson

Re #7679. Puting an endif in the right place.

Changeset: c7522e6d015d04aab251a0823c067b3985d2219e

comment:5 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​feature/7679_compiler_warnings.

To test:

  • It is easiest to look at the number of compiler warnings in ​the builds and that they have gone down.
  • Also ​cppcheck builds will have decreased (slightly).

comment:6 Changed 7 years ago by Peter Peterson

  • Blocking 6475 added

(In #6475) The suppressions via pragmas look legitimate so this ticket is to change them to use the new header introduced by #7679.

comment:6 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Blocking 6475 removed
  • Tester set to Michael Reuter

comment:7 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

A couple of warnings are still present.

comment:9 Changed 7 years ago by Pete Peterson

  • Status changed from reopened to inprogress

Re #7679. Quieting more compiler warnings.

Changeset: 6cac31aa915aa54460f17dd8a360b15b1df7af91

comment:10 Changed 7 years ago by Peter Peterson

Re #7679. Don't pop warnings for big compile includes.

Changeset: aed9dd0a0d48d488afad80bbf92fa6d2b6698a24

comment:11 Changed 7 years ago by Peter Peterson

Re #7679. Removing turning warning back on.

Changeset: 62642e663c14d6af8ab069eb7e93510eea8dd3a1

comment:12 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 7 years ago by Peter Peterson

It should be mentioned that some of the warnings that are left should go away when the old python api disappears (soon).

comment:14 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:15 Changed 7 years ago by Michael Reuter

The issues left do deal with the v1 Python API. Pete can't do Windoze work so that isn't effected here.

comment:16 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7679_compiler_warnings'

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8524

Note: See TracTickets for help on using tickets.