Ticket #7694 (closed: fixed)
Move LoadMultipleGSS.py to new API
| Reported by: | Gesner Passos | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.0 |
| Component: | Python | Keywords: | |
| Cc: | Blocked By: | #7128 | |
| Blocking: | #7690 | Tester: | Gesner Passos |
Description
Move also the file to PythonInterface/plugins/algorithms/
I assumed the last person to touch the code is the owner.
Attachments
Change History
comment:4 Changed 7 years ago by Peter Peterson
Re #7694. Moving to directory for new python api.
Changeset: c79f70ef91275f317cf902b599b7afceeac892d3
comment:5 Changed 7 years ago by Peter Peterson
Re #7694. Converted to use new python api.
Changeset: aa538a7258c8c9fced3f3c170105171d63dc1af2
comment:6 Changed 7 years ago by Peter Peterson
Re #7694. Adding a bit of wiki to LoadMultipleGSS.
Changeset: a1e861920bf148cc3d050e2b82591c55575ad0ca
comment:7 Changed 7 years ago by Peter Peterson
This is on feature/7694_loadmultgss_pyapi?w=1. The branch has changes for #7128 as well so just verify both.
To test:
- See that the imports reference the new API
- Try running using the attached gsas file
comment:8 Changed 7 years ago by Peter Peterson
The new algorithm location doesn't make it into the build correctly.
comment:9 Changed 7 years ago by Russell Taylor
Re #7694. Comment out PythonAlgorithms install as it's gone.
The directory disappeared with the last file that was in it, leading to an error on making the package.
Changeset: 3fb20bf0c447a678147ba00d4fd6d4699ac73cbd
comment:10 Changed 7 years ago by Gesner Passos
There is an error if you provide a wrong input, in line 31
raise RuntimeError("Failed to load run %s" % str(run))
run has not been specified in that section.
comment:11 Changed 7 years ago by Peter Peterson
Re #7694. Fixed RuntimeError message.
Changeset: c07d73fa2dabacd0ebd6f7571ea2956b8b737d71
comment:12 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:14 Changed 7 years ago by Gesner Passos
- Status changed from verifying to closed
Cheers up! The last algorithm in the old API has gone.
It is correctly translated and working.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8539
