Ticket #7700 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Straighten out initialize and create function vtkSplatterPlotFactory

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.0
Component: GUI Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description (last modified by Michael Reuter) (diff)

The initialize function has duplicate checks. The create function needs to take one of those back.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress
  • Description modified (diff)

comment:2 Changed 7 years ago by Michael Reuter

  • Description modified (diff)
  • Summary changed from Remove initialize function from vtkSplatterPlotFactory to Straighten out initialize and create function vtkSplatterPlotFactory

After reviewing this a bit closer, I've reoriented the direction of the ticket.

comment:3 Changed 7 years ago by Michael Reuter

Refs #7700. Moving duplicate checks.

This is back to the contract estabilished by the vtkDataSetFactory, but it still allows me to handle things at the right time. Putting a unit test back as well.

Changeset: 0a1624b527c24fe070707bed0d070f1c25719212

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch is ​here.

To test:

  1. Check that the vtkSplatterPlotFactoryTest unit test runs correctly.
  2. Load up a 3D MDEventWorkspace in the VSI and make sure the SplatterPlot is still working.

comment:5 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:6 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8545

Note: See TracTickets for help on using tickets.