Ticket #7705 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Load not working with Dave grouped file with different extension

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: critical Milestone: Release 2.6.1
Component: Framework Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

At SNS, we've used in the past the .dat extension for DAVE grouped ascii files. The current LoadDaveGrp loader doesn't consider these type of files. This should be fixed.

Attachments

BASIS_23640.dat​ (122.4 KB) - added by Michael Reuter 7 years ago.
Example data

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #7705. Adding dat extension to list.

Changeset: 98ec22b528e299f427b5552c0a49099d17a00e22

Changed 7 years ago by Michael Reuter

Example data

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch is ​here

To test: Load the attached file via Load and make sure that LoadDaveGrp is the loader used. Also, check some *.dat files in AutoTestData to make sure that LoadDaveGrp does not pick them up. There aren't any LoadDaveGrp compatible *.dat files there.

comment:4 Changed 7 years ago by Michael Reuter

  • Keywords PatchCandidate added

This broke some user scripts.

comment:5 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Test as specified works, but when I run LoadDaveGrap explicitly the browse dialog box does not give a choice of filetype *.dat .

This can be easily fixed by modifying the start of LoadDaveGrp::Init.

comment:7 Changed 7 years ago by Michael Reuter

  • Status changed from reopened to inprogress

Forgot about that.

comment:8 Changed 7 years ago by Michael Reuter

Refs #7705. Adding new extension to algo init.

Changeset: 48fcfcd5f5af1caff433129472b863a5e24701cb

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

To finish testing: Check to make sure that *.dat are found when browsing after running LoadDaveGrp directly.

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying

comment:11 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:12 Changed 7 years ago by Karl Palmen

Merge remote-tracking branch 'origin/bugfix/7705_loaddavegrp_extension'

comment:13 Changed 7 years ago by Michael Reuter

  • Milestone changed from Release 3.0 to Release 2.6.1

comment:14 Changed 7 years ago by Michael Reuter

Refs #7705. Adding dat extension to list. (cherry picked from commit 98ec22b528e299f427b5552c0a49099d17a00e22)

Changeset: 933bf726ff194c5a7b43e9eb13261ab8c59161b6

comment:15 Changed 7 years ago by Michael Reuter

Refs #7705. Adding new extension to algo init. (cherry picked from commit 48fcfcd5f5af1caff433129472b863a5e24701cb)

Changeset: 6395978ccfa45f5c1b8db0692645bc00a52e27f7

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8550

Note: See TracTickets for help on using tickets.