Ticket #7713 (closed: wontfix)
[C2E] Remove load logs option from C2E
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Parker |
Description
The load logs option on the C2E interface needs removing. Logs should be loaded by default.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Removed log logs option from code and GUI.
Refs #7713
Changeset: 32630696d3fa5690a2981b730029c57e18927a93
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to wontfix
After checking the performance between loading and not loading logs, I've noticed that there is still a considerable difference on some instruments. After discussing this with the indirect scientists it's been decided that this option would be better left alone.
To Tester
I reverted the above commit to reset my changes. Check that the option is still on the C2E interface and that it works as it always did.
comment:5 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:6 Changed 7 years ago by Peter Parker
- Status changed from verifying to reopened
- Resolution wontfix deleted
As discussed, can't find the revert.
comment:7 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to wontfix
Forgot to do a git publish after the last checkbuild. I should really write a script to just do both at the same time.
comment:9 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7713_remove_load_logs_option'
comment:10 Changed 7 years ago by Peter Parker
Revert was there! Passing.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8558
LoadRaw3 defaults to loading the log files anyway, so the option on the interface doesn't actually do anything.Closer inspection shows that it does still work, however it has apparently been sped up and so loading logs by default shouldn't be an issue anymore. Remove the option and the underlying code.