Ticket #7716 (closed: wontfix)
Create algorithms to store/load grouping files for Muon interface
Reported by: | Arturs Bekasovs | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Muon | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Nick Draper |
Description
LoadMuonDetectorsGroupingFile and SaveMuonDetectorsGrouping should be able to store/load pairing information in addition to the grouping.
Change History
comment:2 Changed 7 years ago by Arturs Bekasovs
- Blocking 7557 added
(In #7557) Some stuff should be done before I can solve that one. When all the "Blocked by" tickets will get solved, I will be able to store all the information in GroupingWorkspace and string describing pairing, load and save all that information using LoadMuonDetectorsGroupingFile and SaveMuonDetectorsGrouping.
So instead of keeping the temporary file, when applying/saving grouping I will parse the information from the GUI to these data structures and use them instead.
comment:3 Changed 7 years ago by Arturs Bekasovs
And, again, after speaking to Martyn I have decided that it makes sense to store information about pairing in log storage as well. Something like:
NoOfPairs: 2 PairName_1: pair_one PairName_2: pair_two PairGroups_1: fwd, bck PairGroups_2: left, right
comment:7 Changed 7 years ago by Arturs Bekasovs
- Blocked By 7765 added
Need to decide whether these algorithms will need to deal specifically with duplicate IDs. If they should, I will probably load/store grouping info as a group or GroupingWorkspaces so that duplicated id's will be allowed. GroupWorkspaces would then just accept such group and use information from all the workspaces.
comment:8 Changed 7 years ago by Arturs Bekasovs
- Milestone changed from Release 3.0 to Backlog
Will not have time for it in this iteration.
comment:10 Changed 7 years ago by Arturs Bekasovs
- Blocked By 7715, 7762, 7765 removed
Rethinking this, the pairing/naming etc. information is purely cosmetic stuff, which helps the users of MuonAnalysis to find the right groups and pairs quickly. We don't really need to store this information in a workspace, because none of the algorithms actually need it, they operate with group numbers / detector lists only.
That's why, it seems perfectly fine for the code to load/save that stuff to be a part of MuonAnalysis interface.
comment:11 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to wontfix
comment:12 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8561
LoadMuonDetectorsGroupingFile should have output parameter for pairing information, which should be represented as a CSV string (look how Fit accept functions). SaveMuonDetectorsGrouping will accept this string as another input parameter.
Both should use the basic functionality of corresponding general grouping loading/storing algorithms, but append (as XML handles?) pairing to be parsed or stored.