Ticket #7727 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

Fixes to the CMake configuration for building the Remote library

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.0
Component: Tools Keywords:
Cc: rgmiller@… Blocked By:
Blocking: Tester: Mathieu Doucet

Description

There are a few issues that need sorting:

  • The Remote library depends on DataObjects when it shouldn't.
  • Everything downstream from Remote is set to depend on it when they shouldn't.
  • The MAKE_REMOTE variable is declared in the top-level CMakeLists.txt which means that it is always false - and so the Remote stuff is not built - for a framework-only build such as the MPI build. This isn't a problem as such but it does lead to that log message about "No instantiator registered.." appearing all the time. Actually, that log message should be lowered in priority.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #7727. Remove references to files that aren't in the repo.

Changeset: 07676f8370879025a6bb6f070342e773204f75f4

comment:2 Changed 7 years ago by Russell Taylor

Re #7727. Move MAKE_REMOTE_JOBS flag into CommonSetup.cmake.

That way it can be seen by a framework-only build as well.

Also remove the addition of the Remote library to the core mantid libs and the headers to the include path from the main CMakeLists as nothing outside of Framework is using it.

Changeset: 58653ec618d5ef0fb3583f77d85ed032b544688e

comment:3 Changed 7 years ago by Russell Taylor

Remove dead code (Re #7727, but unrelated to this ticket).

We specify a minimum cmake version of 2.8 now so this message can never show up.

Changeset: 39b8ee6d79c525473e9f88ad09f1398c547f318f

comment:4 Changed 7 years ago by Russell Taylor

Re #7727. Make RemoteAlgorithms the only thing to depend on Remote.

It's the only thing that needs to. This also removes the incorrect dependency of Remote on DataObjects.

Changeset: cdfa139e99554d79e58450ad15bb2e197c8550c9

comment:5 Changed 7 years ago by Russell Taylor

Re #7727. Have Remote depend only on Kernel.

It would be allowed to depend on Geometry & API if it needed to, but since it doesn't for now just keep things minimal.

Changeset: 1594d37953b682d5c2fc3098547a8dc550f507b1

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to invalid

Following completion of #7769, this ticket is no longer relevant as the Remote library has disappeared. I've deleted the branch on github which contained all the above commits.

You still don't get the RemoteAlgorithms built with a Framework-only (e.g. MPI) build, but really the MAKE_REMOTE CMake flag should just go away which would resolve that anomaly.

comment:7 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:8 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Tools

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8572

Note: See TracTickets for help on using tickets.