Ticket #7737 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

FilterByTime into same workspace wipes out all the events

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

If you have the same output as input workspace then everything gets wiped out because one of the first things that EventList::filterByPulseTime does is clear all events out of the output EventList, which is of course the input one in this situation!

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #7737. Add (failing) tests that expose the bug.

Changeset: 638dc4fb25085c1e0ac8d3d30278c1b53e812916

comment:2 Changed 7 years ago by Russell Taylor

Re #7737. EventList::filterByPulseTime throws if filtering in-place.

Since this method clears the 'output' EventList, it can't be the same one as the input.

Changeset: b91aa925de50b822a52b9df6de4751565f767fa8

comment:3 Changed 7 years ago by Russell Taylor

Re #7737. Always create an output workspace.

You cannot filter in-place.

Changeset: 5ab3e481ec68e35e3f80d22dc2fab687941b6ac8

comment:4 Changed 7 years ago by Russell Taylor

Re #7737. Formatting only: change tabs to spaces.

Changeset: defb377760dde3f9c20ef2b630b8649e287d0de1

comment:5 Changed 7 years ago by Russell Taylor

Re #7737. Fix EventList cppcheck warnings.

Changeset: 90c992b343e573c050c5529922e3ca396f39cd5a

comment:6 Changed 7 years ago by Russell Taylor

Re #7737. Add a performance test.

Changeset: 218063c7c785639d28f55ed12f738ffc750f1c0b

comment:7 Changed 7 years ago by Russell Taylor

Re #7737. Create algorithms on the stack, not the heap.

Changeset: 1c46d113a545511d2cb93816c1a66bd3c1035508

comment:8 Changed 7 years ago by Russell Taylor

Re #7737. Refactor test to not load data.

Changeset: c4fa22d026f28f8adc3312f14d3b1e2936912b47

comment:9 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: the branch is bugfix/7737_filterbytime_same_input_output

I did a bit of housekeeping here are the same time. The commit that fixed the bug is the one in comment:3

comment:10 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:11 Changed 7 years ago by Russell Taylor

Re #7737. Remove no-longer-used variables.

Changeset: d84ef740f3bbf87d1ba955834bf5aec9a843d7c2

comment:12 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7737_filterbytime_same_input_output'

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8582

Note: See TracTickets for help on using tickets.