Ticket #7739 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make LoadFullprofProfile to load all banks from a multi-bank .irf file

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #6968 Tester: Peter Peterson

Description


Attachments

pg60_2011B.irf​ (6.0 KB) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

Checkpointing work. Refs #7739.

Changeset: 7e364487df6f1fb5f9399d31d595d9aee99023ac

comment:2 Changed 7 years ago by Wenduo Zhou

Checkpointing work (60%). Refs #7739.

Changeset: af7a4fa787f2ba4040580e47c86c92a9dfbc09b7

comment:3 Changed 7 years ago by Wenduo Zhou

Fixed some issues. Refs #7739.

Changeset: 8e38115c7b72129a31c3b16237aa1f7118ecc496

comment:4 Changed 7 years ago by Wenduo Zhou

Expanded unit test for the new feature. Refs #7739.

Changeset: 55826f372341427198843034c65e6d30fa93fe9e

Changed 7 years ago by Wenduo Zhou

comment:5 Changed 7 years ago by Wenduo Zhou

Fixed a bug. Refs #7739.

Changeset: a6cade558cb556af4a0c3200b319b6977fd08601

comment:6 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

Verification

  1. Download the attached pg60_2011B.irf. It contains parameters for 7 banks.
  2. Run LoadFullprofResolution with pg60_2011B.irf as input. Try input a single bank number of leave it bank.

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

It works as advertised, but it should be modified to allow a sequence of Banks (i.e. Bank=1-3).

As a side note, the "correct" way to check for a parameter being set to an empty value is 

if(isEmpty(outputbankid))

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

Changed 'Bank' to 'Banks'. Refs #7739.

Changeset: 552594cb32440f8a44adeb9565c9da07b8eca4fa

comment:10 Changed 7 years ago by Wenduo Zhou

Modified due to change of interface. Refs #7739.

Changeset: 1871eaf437888188ade4ff529d09bd5b263acb47

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

Property 'Bank' is modified to 'Banks' to take a list of banks IDs.

comment:12 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:13 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:14 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8584

Note: See TracTickets for help on using tickets.