Ticket #7742 (closed: fixed)
Remove CustomUnits
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
There is a type of Unit called CustomUnit defined in Unit.h which does exactly the same thing as Label and should be removed. The class appears to only be used in the ConvertAxisByFormula algorithm.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
To Test
CustomUnits has been removed from the project as it provided the same functionality as Label. Do a code inspection to check that the changes are reasonable. Also try running ConvertAxisByFormula with some sensible input and check that changing the units works as expected.
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
The new Label constructor should consume its string arguments by reference-to-const (i.e. const std::string&). There should be a unit test for the constructor (I appreciate that there are none at all for the Label unit at present - feel free, though not obliged, to add them for methods other than the one you added).
comment:7 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Changed constructor to pass by ref to const.
Refs #7742
Changeset: f0d84887bea73ac690ad9223f5731cf3538cd36d
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Good stuff.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8587
Removed CustomUnits from project.
Refs #7742
Changeset: 470e89a4171fcdfdb501b342dc32b257b458fec1