Ticket #7751 (closed: fixed)
Hunt for unit tests having constructors that do work that don't have 'boilerplate' protection
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
Find all the unit tests that have constructors that do work but are missing the magic code to stop the constructor being run every time any test in that package is run.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #7751. Revert this one - it makes the test fail for some reason.
And just trying to start up the FrameworkManager another way doesn't fix it.
Changeset: 6bdb7a21f94c709984129d777c094c208baa9e23
comment:3 Changed 7 years ago by Russell Taylor
Re #7751. Make sure the FrameworkManager is started for tests.
The LeBailFit test was relying on it being started, but was getting it by luck before.
Changeset: bbb54210234e9493774ab26782e3d5cb5fe947fa
comment:4 Changed 7 years ago by Russell Taylor
The initial commit was done under wrong ticket number:
Re #7551. Add code to prevent test constructors being called too much.
Changeset: bbb85b529b5984293c007d6352e81a0366652200
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: Branch is feature/7751_protect_test_constructors
Really just check that the tests are all passing and look over the changes.
comment:6 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:7 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7751_protect_test_constructors'
comment:8 Changed 7 years ago by Russell Taylor
- Status changed from closed to reopened
- Resolution fixed deleted
Some tests failed on Ubuntu.
comment:9 Changed 7 years ago by Russell Taylor
- Status changed from reopened to inprogress
Re #7751. Make sure the FrameworkManager is started.
This is required on Ubuntu. I think it relates to the fact that the tested algorithms use subalgorithms from another package.
Changeset: 7daaea9def5b37f2c25ccf7b4cf7558cd2dec434
comment:10 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Things should be fine everywhere now, but just in case THIS MUST BE TESTED ON UBUNTU!
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7751_protect_test_constructors'
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8596
