Ticket #7754 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix cppcheck issues for Vates package

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

This ticket will address the cppcheck issues for all of the Vates subdirectory code.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #7754. Fixing (most) VatesAPI directory cppcheck issues.

Changeset: d9b09a4b867a34b517b5f353ec4354d5278321ae

comment:3 Changed 7 years ago by Michael Reuter

Refs #7754. Suppressing false positive.

If the offending code wasn't read, the plugin wouldn't work, no data would be shown and people would be unhappy.

Changeset: 912aaeeb4eec3770f2cce6cbd9b7b43a9634eeff

comment:4 Changed 7 years ago by Michael Reuter

Refs #7754. Suppressing ParaView export symbols.

Since we can't always know where the ParaView source code lives and we don't want cppcheck checking the ParaView code, we'll just have to suppress the dll export symbols.

Changeset: 924415c4c5df7d30d0679c7368f1eadbd285664b

comment:5 Changed 7 years ago by Michael Reuter

Refs #7754. More suppression of dll export symbols.

I think these are things that cppcheck should be handling correctly, but it isn't. I see that there are other places in the code where it is having a similar issue, so this code isn't alone.

Changeset: 56c063948f8d43daa35eb6d54de58297b4eb98f8

comment:6 Changed 7 years ago by Michael Reuter

Refs #7754. Resolving conflict.

Changeset: 7d06ea320e5e2bcd6cc71533274b41cb6f49a4a0

comment:7 Changed 7 years ago by Michael Reuter

The conflict only got resolved on develop.

comment:8 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch is ​here

To test: Run cppcheck before and after and see that all of the Vates files are clean.

comment:9 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:10 Changed 7 years ago by Peter Peterson

Merge remote branch 'origin/feature/7754_cppcheck_vates'

Conflicts:

Code/Mantid/Vates/VatesAPI/src/vtkSplatterPlotFactory.cpp

Refs #7754.

Changeset: c17885ecaed8aefcedfe6721ea1f28f2ba73944a

comment:11 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

I verified this on RHEL6 with cppcheck 1.59.

  • Before merging branch: 452 issues
  • After merging the branch: 422 issues - none of which appear to be in vates related code.

comment:12 Changed 7 years ago by Michael Reuter

Refs #7754. Resolving conflict.

Changeset: 7d06ea320e5e2bcd6cc71533274b41cb6f49a4a0

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8599

Note: See TracTickets for help on using tickets.