Ticket #7758 (closed: fixed)
Correct mistake in MUSR_Definition
| Reported by: | Anders Markvardsen | Owned by: | Mike Thomas |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Muon | Keywords: | |
| Cc: | michael.thomas@… | Blocked By: | |
| Blocking: | Tester: | Gesner Passos |
Description
Currently reads
<component type="both rings" idlist="both rings">
<location /> <!-- Here link orientation of instrument to horizontal or vertical in Nexus file--> <parameter name="roty" logfile-id="fromNexus" extract-single-value-as="position 1" />
</component>
It should read
<component type="both rings" idlist="both rings">
<location /> <!-- Here link orientation of instrument to horizontal or vertical in Nexus file--> <parameter name="roty">
<logfile id="fromNexus" extract-single-value-as="position 1"/>
</parameter>
</component>
Steve will email two run numbers for the two orientations of MUSR
Change History
comment:2 Changed 7 years ago by Mike Thomas
- Status changed from new to inprogress
Correction of mistake in MuSR IDF. RE #7758
Changeset: ec624c0afb273628f6cb6529d809328c1285a16f
comment:5 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To tester:
- Open MantidPlot
- Load MuSR runs 44904
- view instrument which have the instrument pointing in one direction (possibly z-axis going through the detector rings)
- Close down MantidPlot
- Load MuSR runs 44905 and view instrument which now will point in a different direction
comment:6 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:7 Changed 7 years ago by Gesner Passos
- Status changed from verifying to closed
The changed IDF non only pass the test of the schema validation but also makes the instrument view to correctly interpret the direction.
comment:8 Changed 7 years ago by Gesner Passos
Merge remote-tracking branch 'origin/feature/7758_Muon_IDF_change'
comment:9 Changed 7 years ago by Nick Draper
- Owner changed from Anders Markvardsen to Mike Thomas
After the summer contact Anders Markvardsen about these tickets
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8603
I have tested the suggested replacement code with the data from two runs, one of each orientation. The instrument orientation can now be seen to change in 'show instrument'.