Ticket #7760 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Convert Indirect workflow algorithms to the new api

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: critical Milestone: Release 3.0
Component: Python Keywords:
Cc: Blocked By:
Blocking: #4889, #7690 Tester: Martyn Gigg

Description

Convert the following workflow algorithms to the new api

Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/Quest.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/JumpFit.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/iFudge.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/MuscatFunc.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/ResNorm.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/ForCE.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/Moments.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/ILLines.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/IDAtransmission.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/Symmetrise.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/QLines.py
Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/MuscatData.py

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

The idea here is to cherry-pick the commits from 7690 to allow Samuel to continue his work.

comment:2 Changed 7 years ago by Gesner Passos

Migrate WorkflowAlgorithms to new API

re #7690

Changeset: b04a293a66a50e99af2aa0cc93dbf7a30f0745dc

moved to ticket #7760

comment:3 Changed 7 years ago by Gesner Passos

Solves the system tests that are failing

the problem was with importing the modules in the very beggining. It was necessary to let the modules to be imported in run time.

re #7690

Changeset: 1899a1c157f0566a71a43fd70b1b824ad348da3a

moved to ticket #7760

comment:4 Changed 7 years ago by Gesner Passos

Correct WorkflowAlgorithms for IndirectAnalysis

It is necessary to import the modules later un RunTime, otherwise, it fails if it tries in the very beggining.

re #7690

Changeset: a31d12e9b16a734391be0d34fe5db5ce8d71eff5

moved to ticket #7760

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Gesner Passos

Tester:

  • executing the reductions involving indirect analysis, should not print warning that it is calling the old API anymore.
  • code review to verify that old api is not being called.

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/7760_workflow_alg_api'

comment:8 Changed 7 years ago by Samuel Jackson

Everything appears to still work in the Indirect interface and there are no longer any python warnings about the old API. Visual code inspection show changes appear to be reasonable.

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:10 Changed 7 years ago by Gesner Passos

Some of the workflow algorithms used the os that was imported 'by chance', automatically from the old api.

It is necessary to add the import line now.

Besides, these workflow algorithms do not have unit tests, and a ticket but be created to check that their wrapper function is being executed correctly.

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from reopened to inprogress

Include the os module for some workflow algorithms

The os was available before in the old api when import all, it has passed without notice.

Now, it has been bassed to those scripts using the os module.

re #7760

Changeset: 5cd5c2fcc61c2d41938ee065af6142aca3d09c71

comment:12 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 7 years ago by Gesner Passos

Change priority of (testing) to critical. This and #7703 block us to switch off old API.

comment:14 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:15 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to verify
  • Tester Samuel Jackson deleted

comment:16 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:17 Changed 7 years ago by Martyn Gigg

Testing only pertains to the last commit as the rest was actually merged to master.

comment:18 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7760_workflow_import_os'

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8605

Note: See TracTickets for help on using tickets.