Ticket #7768 (closed: fixed)
Expand the unit options for giving a filtering range in the Step Scan Interface
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | LiveData |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Wenduo Zhou |
Description
Right now it only takes TOF, I need to add others.
Change History
comment:2 Changed 7 years ago by Russell Taylor
- Status changed from new to inprogress
Re #7768. Add d-spacing as an available filtering unit.
Garrett says that this is the one he would use most often.
Changeset: bead86f9718a5e2c20be65643a81a601a3f5df1c
comment:3 Changed 7 years ago by Russell Taylor
Re #7768. Ensure selected variable doesn't get forgotten.
Previously, even if the user had chosen something else it would revert to scan_index if the dataset was being filtered.
Changeset: b79020fb9d4ea123494ab3593c3d1e2505eecba8
comment:4 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: Branch is feature/7768_stepscan_filtering_units
In discussion with Andrei I decided to just add d-spacing at this time. Although things will work with any convertible unit I prefer to restrict things until people ask for others. The other likely candidate would be Q, but that's a simple conversion from d-spacing that Andrei could do in his head :)
To test, start up the Step Scan Analysis Interface and notice that the combobox under Data Filtering - Range now has an entry for d-spacing. You could test it with the HYSA_2934 file in the systemtests repo. Most of the data in that file is in the d-spacing range 3.2-3.6 angstroms.
The second commit isn't completely related to this ticket, but fixed a bug that if you have any filtering and had chosen a plot variable other than scan_index, it would flip back to scan_index after you pressed start.
comment:5 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:7 Changed 7 years ago by Russell Taylor
Re #7768. Add d-spacing as an available filtering unit.
Garrett says that this is the one he would use most often.
Changeset: 4faba61c54a0e552bee8ff11bf0eec6293fdb980
comment:8 Changed 7 years ago by Russell Taylor
Re #7768. Ensure selected variable doesn't get forgotten.
Previously, even if the user had chosen something else it would revert to scan_index if the dataset was being filtered.
Changeset: fadfebb67def7d2eac8f760118c283d9137ddb86
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8613
Garrett says that the one he'd use most is d-spacing.