Ticket #7770 (closed: fixed)
New reduction_workflow uses old reduction scripts
| Reported by: | Mathieu Doucet | Owned by: | Mathieu Doucet |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
Found a bad import in the reduction_workflow module. In reduction_workflow/instruments/sans/sns_command_interface.py, line 36:
from reduction.find_data import find_data
should be
from reduction_workflow.find_data import find_data
Change History
comment:2 Changed 7 years ago by Mathieu Doucet
- Status changed from inprogress to verify
- Resolution set to fixed
To test:
- Confirm the change
- Make sure EQSANS system tests work
comment:3 Changed 7 years ago by Mathieu Doucet
Re #7770 fix old import
Changeset: 218109455612aa153a3782c487bb84f07b4bb26b
comment:4 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:5 Changed 7 years ago by Jay Rainey
I receive an error saying that the changes need to be merged with develop in order for me to begin testing.
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:7 Changed 7 years ago by Mathieu Doucet
- Status changed from reopened to verify
- Resolution set to fixed
comment:9 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7770_fix_apiv1_import'
comment:10 Changed 7 years ago by Jay Rainey
Import changed as expected, and all tests passed.
comment:11 Changed 7 years ago by Mathieu Doucet
Re #7770 fix old import
Changeset: 218109455612aa153a3782c487bb84f07b4bb26b
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8615
Note: See
TracTickets for help on using
tickets.
Re #7770 fix old import
Changeset: d3a64828e7ba53c6eb96789bb29c235e794c7641