ConvertTableToMatrixWorkspace: Default error is wrong

[Russell Taylor]

While doing #7767, I noticed that the author of ConvertTableToMatrixWorkspace inexplicably chose to set the errors to 1.0 if no error column is given!

I hope nothing is relying on this behaviour, because I need something more sensible (i.e. 0)!

[Russell Taylor]

Re #7779. Make the default error zero if no error column given.

This is surely more sensible than 1! Also a bit of tidying up in the code around this change.

Changeset: ffe5d42421370bf7242a8624bf33bff65251954d

[Russell Taylor]

Tester: Branch is bugfix/7779_converttabletomatrix_error_default

The crucial change here is the replacement of what was line 73 of ConvertTableToMatrixWorkspace.cpp (it's been replaced by nothing, as a Workspace2D is anyhow created with zeroes initially. To test, somehow create a TableWorkspace and run this algorithm, leaving the ColumnE property empty. You will see that the errors are now 0, where before they were 1.

Around this I just did a little housekeeping. The extra template instantiation in ITableWorkspace.cpp was required when I changed to holding the inputworkspace as a const shared_ptr.

[Wenduo Zhou]

I created a table workspace and convert it to matrix workspace. The column E worked as requested. So the ticket can be closed.

[Wenduo Zhou]

Merge remote-tracking branch 'origin/bugfix/7779_converttabletomatrix_error_default'

[Stuart Campbell]

This ticket has been transferred to github issue ​8624