Ticket #7783 (closed: fixed)
Use FindPeakBackground in FindPeaks
| Reported by: | Vickie Lynch | Owned by: | Vickie Lynch |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | #7449 | |
| Blocking: | Tester: | Russell Taylor |
Description (last modified by Vickie Lynch) (diff)
Use peak range and background estimate in FindPeakBackground.
Change History
comment:3 Changed 7 years ago by Vickie Lynch
- Status changed from new to inprogress
Refs #7783 use FindPeakBackground in FindPeaks
Changeset: 7bd81b7164ce395b3a64b90077f4322dd3e9abdb
comment:4 Changed 7 years ago by Vickie Lynch
Refs #7783 subtract i_min from peak boundaries
Changeset: 2a0bf22c3f2e6d721040f6e530fcbe2f1ee9c475
comment:5 Changed 7 years ago by Vickie Lynch
Refs #7783 more peaks for diamond calibration
Changeset: e52a9e7502793eb53dbc70fa5cdf31d9ab36ebe1
comment:6 Changed 7 years ago by Vickie Lynch
Refs #7783 golden data updated
Changeset: c6686fe226d1fcf2034be930f86bd8557714e9c5
comment:7 Changed 7 years ago by Vickie Lynch
Refs #7783 fix valgrid errors
Changeset: b9fe0500f0e8e46993bdbe9ab4ddd0474c85049c
comment:8 Changed 7 years ago by Peter Peterson
I'm becoming suspicious that the golden data should not have been updated.
comment:9 Changed 7 years ago by Vickie Lynch
Refs #7783 golden data updated again
Changeset: b7a2dc370e7292e955ce8055068b6616cf927d36
comment:10 Changed 7 years ago by Vickie Lynch
Refs #7783 use same background type
Changeset: d288f2934972f061aae2a5f9684b39a25681db72
comment:11 Changed 7 years ago by Vickie Lynch
Refs #7783 golden data updated again
Changeset: 541e8f68dc814580a2aee05a8efe973e3ae0029c
comment:12 Changed 7 years ago by Peter Peterson
Re #7783. Pick estimate with best chisq
Changeset: 534543ba4bdcab62f99fb75d2876b7a9b79bded7
comment:13 Changed 7 years ago by Vickie Lynch
Refs #7783 slightly increase tolerance
Changeset: 4a790266554fc0b5c7a290f04c4194cad93d4e4f
comment:14 Changed 7 years ago by Vickie Lynch
- Status changed from inprogress to verify
- Resolution set to fixed
Calibration system test passes
comment:15 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:16 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
The redundant FindPeaks::estimateBackground method needs removing. And a small one: in fitPeakHighBackground don't pass an int (4 bytes) by const-ref (8 bytes).
comment:18 Changed 7 years ago by Vickie Lynch
Refs #7783 remove estimateBackground;use int in fitPeakHighBackground
Changeset: 78ceb54275bddd3ecc4afe020e6073acc76eb35c
comment:19 Changed 7 years ago by Vickie Lynch
Revert "Refs #7783 remove estimateBackground;use int in fitPeakHighBackground"
This reverts commit 78ceb54275bddd3ecc4afe020e6073acc76eb35c.
Changeset: 189af9acc1aee05ee772aa44ffe1e23d419af1c6
comment:20 Changed 7 years ago by Vickie Lynch
Refs #7783 change to int;fit from information to debug
Changeset: 59fd67e8864c5a69c6d64778024a22c36ad4288c
comment:21 Changed 7 years ago by Vickie Lynch
- Status changed from inprogress to verify
- Resolution set to fixed
feature/7783_FindPeaks_background branch in both mantid and SytemTests
comment:22 Changed 7 years ago by Vickie Lynch
Refs #7783 faster system test
Changeset: b42391b55136758cb04a28ec5d85295e81b5aefa
comment:24 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/feature/7783_FindPeaks_background'
comment:25 Changed 7 years ago by Russell Taylor
Merge remote branch 'origin/feature/7783_FindPeaks_background'
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8628
