Ticket #7787 (closed: fixed)
Updates for DGS
| Reported by: | Andrei Savici | Owned by: | Andrei Savici |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
DgsReduction should have an entry to LevelUp for MedianDetectorTest
Change History
comment:2 Changed 7 years ago by Andrei Savici
Add dgs LevelsUp input. Refs #7787
Changeset: 22bd7bf3aafb8293c2061e33406c7a9044a70fcb
comment:3 Changed 7 years ago by Andrei Savici
Correct for Solid Angle option in DgsReduction diagnostic. Refs #7787
Also fixed SaveVanadium option to be visible in the auto-generated gui
Changeset: 39d2187d088e56ffd9dc8844d3d3d7420d8cc62d
comment:4 Changed 7 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
To be tested by someone at SNS. Try to reduce an ARCS file, the vanadium run 37348 should have bank M14 masked with LevelsUp=0, and not masked for LevelsUp=1. Also to be tested:
- save processed detector vanadium option appears in DgsReduction autogenerated GUI
- solid angle correction appears in autogenerated GUI
- solid angle correction appears in DetectorDiagnostics
comment:5 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:6 Changed 7 years ago by Russell Taylor
There's a compiler warning from this - WorkflowAlgorithmHelpers.cpp:98
comment:7 Changed 7 years ago by Andrei Savici
Fix warning. Refs #7787
Changeset: 55cf2629ca87cc718d85e26cfa25c7aa15e5ec55
comment:8 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
This broke the DirectInelasticDiagnostic2 system test.
comment:9 Changed 7 years ago by Andrei Savici
- Status changed from reopened to inprogress
Try to fix systemtest. Refs #7787
It seems like python has problems with passing ints through property manager. Switching to double
Changeset: 3e955addfaed7cd7189f62905a70a46568afae6d
comment:10 Changed 7 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
The LevelsUp does not seem to have any effect.
comment:13 Changed 7 years ago by Andrei Savici
- Status changed from reopened to inprogress
Override parameters in reduction properties. Refs #7787
Changeset: e7e979a2034b1813832e2d30eefd8d1d65f56074
comment:14 Changed 7 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
The automatic closer failed to close this ticket since the merge was already done.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8632
