Ticket #7794 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct invalid attributes within HYSPECA_Definition.xml IDF

Reported by: Mike Thomas Owned by: Mike Thomas
Priority: major Milestone: Release 3.0
Component: Direct Inelastic Keywords: IDF HYSPEC
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Incorrectly named location elements of the HYSPECA IDF will be removed as they are later defined in <parameter> elements. This will have no effect on the instrument loaded into mantid. The change is required in order for the IDF to validate the new IDF Schema.

Erroneous Code:

<component type=”Tank” idlist=”Tank”>

<location t-position=”70.148” roty=”70.148”>

<parameter name=”r-position”>

<value val=”0”/>

</parameter>

Replacement Code:

<component type=”Tank” idlist=”Tank”>

<location>

<parameter name=”r-position”>

<value val=”0”/>

</parameter>

Change History

comment:1 Changed 7 years ago by Mike Thomas

  • Status changed from new to inprogress

Commit HYSPECA_Def corrected Refs #7794

Changeset: a7580cab5605d0baa05fbe033eabe4d21665d754

comment:2 Changed 7 years ago by Mike Thomas

  • Owner set to Anders Markvardsen

comment:3 Changed 7 years ago by Michael Reuter

This has been address in #7781 already.

comment:4 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester: check HYSPECA_Definition.xml changed according to description

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to verify
  • Tester Jay Rainey deleted

comment:7 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Since the same changes were made in #7781, which has been merged to master, I just deleted the branch created for this ticket on github.

comment:10 Changed 7 years ago by Nick Draper

  • Owner changed from Anders Markvardsen to Mike Thomas

After the summer contact Anders Markvardsen about these tickets

comment:11 Changed 7 years ago by Mike Thomas

Commit HYSPECA_Def corrected Refs #7794

Changeset: a7580cab5605d0baa05fbe033eabe4d21665d754

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Direct Inelastic

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8639

Note: See TracTickets for help on using tickets.