Ticket #7799 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

CalibrateRectangularDetectors on SNAP

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Release 3.0
Component: Diffraction Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The multi-peaks option doesn't work for two reasons:

  1. SumNeighbors accidentally finds a monitor as a regular detector so doesn't use the rectangular detectors option
  2. CalibrateRectangularDetectors has some special branches for SNAP which are no longer necessary. Remove them other than the special case when loading prenexus files.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #7799. Setting the second monitor as a monitor on SNAP.

Changeset: 4520dbfc510ba1ec67851eb34ae2e9987ca475db

comment:2 Changed 7 years ago by Peter Peterson

Re #7799. Removing SNAP specific branches from CalibrateRectDetectors.

Changeset: efdd33a85ad4f58e74c52e040679df525f7434e7

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on bugfix/7799_snap_calibration.

To test:

  1. Look at the new version of the SNAP geometry file.
  2. Run CalibrateRectangularDetectors with SNAP_12696, and sumx=64, sumy=64, and peak positions of .8258,.9046,1.0113,1.1678,1.4303,2.0227 and DiffractionFocus the result turned on. This shouldn't take forever to run and should give reasonable peaks.

comment:4 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:5 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Calibration looks good and took only 43 seconds. PG3 calibration still works.

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8644

Note: See TracTickets for help on using tickets.