Ticket #7818 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ORNL SANS: fix detector side masking

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.0
Component: SANS Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

The ORNL SANS detector have two planes of tubes. There used to be an option to mask on of the two planes (front side or back side) but it no longer works. The problem is in the way the instrument parameters are accessed.

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Mathieu Doucet

Re #7818 Fix masking issue

Changeset: f65894ada19b6981ea866a3cd1ec418479d13e7f

comment:3 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test: Execute the following script, click "Show Instrument", and see that the detector has zebra stripes where every second tube (along y-axis) is masked.

import mantid
from mantid.simpleapi import *
from reduction_workflow.instruments.sans.hfir_command_interface import *

BIOSANS()
SetSampleDetectorOffset(837.9)
SolidAngle(detector_tubes=True)
MonitorNormalization()
AzimuthalAverage(n_bins=100, n_subpix=1, log_binning=False)
NoIQxQy()
SetBeamCenter(96.7, 16.6)
NoSensitivityCorrection()
SetTransmission(1.0,0.0)
ThetaDependentTransmission(False)
AppendDataFile(["BioSANS_test_data.xml"])
NoSaveIq()
MaskDetectorSide('Back')
Reduce()

comment:4 Changed 7 years ago by Mathieu Doucet

  • Keywords PatchCandidate added

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Now masks one of the two planes (producing zebra stripes). Easy to understand code.

Not sure why trac didn't auto update when I passed the ticket. Commit can be viewed github.

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Framework to SANS

comment:8 Changed 7 years ago by Vickie Lynch

Last edited 7 years ago by Vickie Lynch (previous) (diff)

comment:9 Changed 7 years ago by Vickie Lynch

Last edited 7 years ago by Vickie Lynch (previous) (diff)

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8663

Note: See TracTickets for help on using tickets.