Flexible Center Tolerance value

[Gesner Passos]

Would it be possible to add another field to the beam centre finder part of the geometry tab which would allow us to change the convergence tolerance? Obviously it could default to whatever values it uses now

[Gesner Passos]

Currently, the value that you are talking about is 0.1251/1000

 if abs(XSTEP) < 0.1251/1000. and abs(YSTEP) < 0.1251/1000. :
  # this is the success criteria, we've close enough to the center
  centre.logger.notice("Converged - check if stuck in local minimum!")
  break

[Gesner Passos]

Rearrange sans function to allow changing the tolerance Seek centre

Inside ISISCommandInterface.py, change the FindBeamCentre in order to allow providing a new value for tolerance. It now, uses the previous values as the default input.

re #7824

Changeset: ec4c1f0b5c24e9c58728e447659e528fa968c007

[Gesner Passos]

Export the tolerance option to GUI SANS interface

re #7824

Changeset: aa2c4c6813bdec6306caa719ad53585374324aee

[Gesner Passos]

Tester:

• open the SANS interface
• change the instrument to LOQ
• Load the user file: systemtests/Data/LOQ/MASK.094AA
• Load the sample file: systemtests/Data/LOQ/LOQ54431.raw
• Change to the Geometry Tab
• check that there is a entry available for tolerance
• Run the auto search.
• It will take 7 iteractions to convert.
• Put the values of the centre back: 324.64, 327.92
• Change the tolerance to a bigger value: For example 5.0
• If you put 5.0, the auto-search will stop on the iteration 5.

[Jay Rainey]

If values are input that are negative, or words then the default value it used. That's great, but the user isn't told about it.

[Owen Arnold]

refs #7824. Make regex more flexible.

Effectively introduce an OR into the regex. This allows it to process the newer form of the HKL coordinate transform labels. Should also still work with the old ones.

Changeset: b9f3cd99ee97baeb85966022add3ad3caee3faa6

Edit - Should have gone against ticket 7827

[Owen Arnold]

refs #7824. Correct Regex.

Changeset: 7f2fb4fe73d6264d66bb5c17a8a4ba01539488e7

Edit - Should have gone against ticket 7827

[Gesner Passos]

Alert user for invalid input for Tolerance

re #7824

Changeset: cf3c982a3d22305604e6141baa9319d5d83eb013

[Jay Rainey]

Merge remote-tracking branch 'origin/feature/7824_seek_centre'

[Jay Rainey]

No longer accepts negative inputs and valid error message is produced if they are provided.

[Stuart Campbell]

This ticket has been transferred to github issue ​8669