Ticket #7827 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

PeaksOverlays HKL when using ConvertToMD

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The workspace outputs are different between ConvertToMD (newer) and the older ConvertToDiffractionMDWorkspace algorithm. In particular the Dimension labels are different, and this means that the PeaksOverlay does not recognise the output workspace as one that can be overplotted.

Follow the usual SC Workflow

  • Create a MDWorkspace using ConvertToMD in QLab
  • FindPeaksMD on the Workspace
  • Find the UB from the PeaksWorkspace and Index the PeaksWorkspace
  • Copy the UB over to the input EventWorkspace
  • Repeat ConvertToMD, but this time convert to HKL
  • Plot the output HKL workspace in the SliceViewer, notice that the Peaks Overlay button (star) is disabled.

The procedure above works if you use ConvertToDiffractionMDWorkspace (version 1) rather than ConvertToMD.

This is probably an issue with an inflexible Regex, however, it should also be possible to getSpecialCoordinates and determine the coordinate system that way round.

Attachments

ConvertToMDUnitTests.py (1.2 KB) - added by Owen Arnold 7 years ago.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress
  • Milestone changed from Backlog to Release 3.0

comment:2 Changed 7 years ago by Owen Arnold

One thing we can and should do here now, as part of these changes is to update the python tests such that they ensure that workspaces generated via ConvertToMD can open (along with respective peaks workspaces in the SliceViewer). This is probably best done under a separate ticket.

These changes should be possible owing to this #7013.

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:3 Changed 7 years ago by Owen Arnold

refs #7824. Make regex more flexible.

Effectively introduce an OR into the regex. This allows it to process the newer form of the HKL coordinate transform labels. Should also still work with the old ones.

Changeset: b9f3cd99ee97baeb85966022add3ad3caee3faa6

comment:4 Changed 7 years ago by Owen Arnold

refs #7824. Correct Regex.

Changeset: 7f2fb4fe73d6264d66bb5c17a8a4ba01539488e7

Changed 7 years ago by Owen Arnold

comment:5 Changed 7 years ago by Owen Arnold

Tester (It would probably be better if the tester for this was familiar with the existing behaviour of the PeaksViewer):

  • Run ConvertToMDUnitTests.py on an old copy of MantidPlot. You should find that you cannot use the PeaksViewer http://www.mantidproject.org/PeaksViewer on the generated HKL workspace.
  • Now build with these changes. Should find that PeaksViewer is enabled, and should overplot the peaks workspace correctly.

I also have unit tests for these changes.

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:8 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7827_fix_hkl_transform'

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8672

Note: See TracTickets for help on using tickets.