Ticket #7841 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[C2E] Calibration Tab: Minor resolution updates

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Jay Rainey

Description

Ticket request from Spencer:

Update the default values used in resolution generation to be the following:

  • rebinning - low/high are +/- 10*resolution from IPF rounded to nearest 0.1
  • width is high/100 rounded to 0.001; background - start is 0.9 low, end is 0.8 low.

Also set the resolution mini plot to auto plot if possible.

Parameters used in resolution generation should be added to logs in the resolution file. Namely: Scale &, if true,Scale Factor; Smooth; Background Start & End; Rebinning low, width & high.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #7841 Auto plot the energy mini-plot

Changeset: 5b8e3791335dae5242b4d99b76f775266dfc4f03

comment:2 Changed 7 years ago by Samuel Jackson

Refs #7841 Add sample logs to resolution file.

Changeset: ebc189a441195c028132bb472b3de26983ce933f

comment:3 Changed 7 years ago by Samuel Jackson

To Tester

The first part of this ticket concerning default values from the IPF has been dealt with in ticket #7870.

Check that when opening a file in the calibration tab the energy mini plot (second one) is also auto-plotted.

Check the following sample logs have been added to the resolution file that gets generated:

  • scale
  • scale_factor - only if scale is true
  • back_start
  • back_end
  • rebin_low
  • rebin_width
  • rebin_high

and that those values match the ones on the interface. The log for smoothing mentioned in the description above has not been added as this feature is not implemented yet and will be added in ticket #7842

comment:4 Changed 7 years ago by Samuel Jackson

Refs #7841 Removed plot energy button.

Also fixed bug where the plotted _red workspace is removed when creating a res file.

Changeset: fb99eb8365659848fb9cbd019bf817fdd467c748

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.0

comment:7 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Does not auto-plot data & energy button is still on GUI.

comment:9 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying

comment:11 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7841_minor_res_updates'

Full changeset: ​095bb6f35c370530d36315a2061d4a4985156b69

comment:12 Changed 7 years ago by Jay Rainey

Correctly auto-plots data when datafile is loaded, and the energy button no longer appears on GUI. The sample logs have been correctly added to the resolution file and match those on the interface.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8686

Note: See TracTickets for help on using tickets.