Ticket #7849 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

By Number of Bins odd behavior

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

The By Number of Bins (bnb) checkbox on the rebinner ParaView plugin is showing some odd behavior. There are two cases where things go funny.

  1. bnb unchecked, but set to checked after applying rebinning with no axis reorientations.
  2. bnb state is correct after applying rebinning with axis reorientations, but fails to cause the Bins/Step box flip without a check/uncheck cycle.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #7849. Making sure things get/keep current state.

Changeset: c3449b224db0b0da96fb9c2d0d8380cb6f111110

comment:3 Changed 7 years ago by Michael Reuter

Refs #7849. Fixing test.

Changeset: f231055f08599effc400136ca4c183d4c6b56421

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch is here.

To test: Please try each of these cases before applying the fix. Both cases start by loading the SEQ_MDEW.nxs file into Mantid and opening the workspace in the VSI. Next, click the Rebin button.

Case 1:

  • Uncheck the By Number of Bins checkbox
  • Click Apply

The By Number of Bins checkbox is checked again in spite of the original state. After the fix, the original state will be remembered.

Restart the VSI between cases.

Case 2:

  • Uncheck the By Number of Bins checkbox
  • Switch the first axis to the T-AXIS via the drop-down box.
  • Click Apply
  • Check the By Number of Bins checkbox

You will notice that the Step box does not change to Bins unless you click the By Number of Bins checkbox twice more. After the fix, the first check will make things swap.

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7849_rebinner_nbn_behavior'

comment:7 Changed 7 years ago by Owen Arnold

Nice to see someone else making use of cardinalities and actions in gmock. Now works exactly as I would expect it to.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8694

Note: See TracTickets for help on using tickets.