Ticket #7851 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[Indirect] ForCE is broken

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: #5422 Tester: Peter Parker

Description

The ForCE algorithm no longer works as it appears the instrument definitions for some of the ILL machines have been removed from the facilities.xml file.

Subsequently the algorithm cannot load the files it needs to run.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Adding instrument definitions to facilities.xml

Refs #7851

Changeset: 7ab22d94c957ec5b750a5418ea2abe003c3136ec

comment:2 Changed 7 years ago by Samuel Jackson

Correcting algorithm to use new getProperty implementation

Refs #7851

Changeset: 994753dd931d1ab415f84b08d6079d616ef4b106

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Samuel Jackson

To Tester

Check that the algorithm no longer has any problems finding the files it needs when running it with some sensible input (e.g. IN16_65722.asc in systemtests). Also check that all the options are being passed correctly from the algorithm to the underlying functions. Do a code inspection of the XML and py algorithm file to check that the changes were appropriate.

comment:5 Changed 7 years ago by Samuel Jackson

  • Blocking 5422 added

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:7 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7851_forCE_is_broken'

Full changeset: ​682cd651f0824ab97ad2c1203d018b70db9c296d

comment:8 Changed 7 years ago by Peter Parker

Passing.

  • Algorithm now finds the suggested IN16 file without any problems.
  • All properties are now being passed correctly.
  • Changes look appropriate.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8696

Note: See TracTickets for help on using tickets.