Ticket #7858 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix broken SCD system tests

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

ReduceOneSCD_Run.ReduceOneSCD_Run and Diffraction_Workflow_Test.Diffraction_Workflow_Test are broken. It looks like the order of the peaks changed. Make CheckWorkspacesMatch deal with this case.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #7858. Use test framework to see if things have changed.

Changeset: f2221021604758da4b40d06d47565568fae743bd

comment:2 Changed 7 years ago by Peter Peterson

Re #7858. Sort peaks by d-spacing before comparing.

Changeset: be1a0edc650691c09e28ad9a48669d5129922447

comment:3 Changed 7 years ago by Peter Peterson

  • Owner changed from Peter Parker to Peter Peterson
  • Status changed from inprogress to verify
  • Resolution set to fixed

The branchname is bugfix/7858_broken_scd and there is one is on both ​mantid and ​systemtests.

To test:

  • Confirm that CheckWorkspacesMatch unit test still works
  • Confirm that the two broken system tests are fixed

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 7 years ago by Russell Taylor

All unit & system tests passed (except the PG3Calibration one that was broken anyway).

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/7858_broken_scd'

comment:7 Changed 7 years ago by Russell Taylor

Merge remote branch 'origin/bugfix/7858_broken_scd'

comment:8 Changed 7 years ago by Peter Peterson

Re #7858. Changed if logic and added unit test to UnitCell.

Changeset: d6f2be2afbec3536d2d1e9a9a9e40bb5d9bdfcd9

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8703

Note: See TracTickets for help on using tickets.