Ticket #7861 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct the migration of isis_reflgui

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.0
Component: Python Keywords:
Cc: Blocked By:
Blocking: #7690 Tester: Jay Rainey

Description

There are still one reference to the old api in the following scripts: 

Mantid/scripts/Reflectometry/isis_reflgui/reflgui.py
Mantid/scripts/Reflectometry/isis_reflgui/quick.py
Mantid/scripts/Reflectometry/isis_reflgui/combineMulti.py

getSampleDetails() must be replaced to getRun() mtd.settings -> must be replaced to config

​http://download.mantidproject.org/docs/current-release/python/html/changes.html#changes

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

Correct the api migration for isis_reflgui scripts

mainly change getSampleDetails to getRun

and one mtd.settings to config.

re #7861

Changeset: cdf963393f0b7f64740121a5a2206af1d1a41383

comment:2 Changed 7 years ago by Gesner Passos

Tester:

I found that following ​http://trac.mantidproject.org/mantid/ticket/7372#comment:15 is good to test that these code were used. 

quick.py:423: DeprecationWarning: 'getSampleDetails' is deprecated, use 'getRun' instead.

comment:3 Changed 7 years ago by Gesner Passos

  • Blocking 7690 added

comment:4 Changed 7 years ago by Gesner Passos

  • Blocking 7690 removed

comment:4 Changed 7 years ago by Gesner Passos

  • Blocking 7690 added

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:8 Changed 7 years ago by Samuel Jackson

Accidentally typed the wrong ticket number on the branch. This commit was actually for #7681

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:9 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7861_reflgui'

comment:10 Changed 7 years ago by Jay Rainey

References from old API have been updated to that of the new API successfully.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8706

Note: See TracTickets for help on using tickets.