Ticket #7862 (closed: fixed)
Refactor ElasticQ Conversions
Reported by: | Samuel Jackson | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Federico M Pouzols |
Description
There's a new conversion function in UnitConversions which has been added as part of ticket #7729 to convert to ElasticQ. An example of its use can be seen at around lines 1124-1131 in MantidUI.cpp.
It would be good if other places in the project could use a similar method of conversion (such as in ConvertSpectrumAxs) to prevent code duplication.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Owner set to Dan Nixon
- Milestone changed from Backlog to Release 3.4
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Use UnitConversion methods in ConvertSpectrumAxis
Refs #7862
Changeset: 9c7cc5997b12e8017e4d828b0dec55e103b0b784
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #169.
comment:7 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:8 Changed 6 years ago by Federico M Pouzols
The code now re-uses Kernel::UnitConversion, and tests pass on build servers and locally.
comment:9 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #169 from mantidproject/feature/7862_refactor_elastic_q_conversions
Use UnitConversion methods in ConvertSpectrumAxis
Full changeset: 5c98d0b081e0ee209495122a1ecaaadf3ea6f6f1
comment:10 Changed 6 years ago by Federico M Pouzols
Merge pull request #169 from mantidproject/feature/7862_refactor_elastic_q_conversions
Use UnitConversion methods in ConvertSpectrumAxis
Full changeset: 5c98d0b081e0ee209495122a1ecaaadf3ea6f6f1
comment:11 Changed 5 years ago by Nick Draper
- Component changed from Framework to Indirect Inelastic
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8707
Bulk move to assigned at the introduction of the triage step