Ticket #7878 (closed: fixed)
Fix memory leaks in absorption correction routines
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
There's some strange (and unnecessary) use of pointers and heap allocations around the handling of the Material class in these algorithms. Consequently there are memory leaks. Fix this.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #7878. Fix memory leaks in tests.
Changeset: 4eb20f0d7c1265a986931308311a1c51dd57e584
comment:3 Changed 7 years ago by Russell Taylor
Re #7878. Fix memory leaks in Crystal package.
More of the same leaks of Material & NeutronAtom.
Changeset: 4844e55dcac4b3f17a8e522115977210a3fd8a81
comment:4 Changed 7 years ago by Russell Taylor
Re #7878. Fix leak of Material object.
Also remove test for null-ness of Material object as inspection shows that can never be the case.
Changeset: 03be3a3bee23722b4e9fe63fa208dc20917254c0
comment:5 Changed 7 years ago by Russell Taylor
Re #7878. Remove no longer needed delete.
Changeset: 2bf30d7b888c101632fd683dd306df3e76ab7691
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: Branch is feature/7878_material_memory_leaks
So long as all tests are passing, this is a code-inspection task - that leaks are gone, but the observable behaviour is unchanged.
comment:7 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
Re #7878. Fix memory leaks in Absorption algorithms
Also don't use pointers/new's unnecessarily.
Changeset: ffc88a3611bbd1f0f46f08d629c1f3586c75aecc