Ticket #7879 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove VectorHelper::iteratorToArray

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

It doesn't do anything that can't be achieved with a standard algorithm, plus it returns a c-style array which we'd rather avoid. So get rid of it.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #7879. Remove VectorHelper::iteratorToArray methods.

Replaced in the one remaining place it was used with standard STL constructs. Not sure why they weren't used in the first place.

Changeset: d3d758d95fe032e831ce9f8d076fd4c77eaf61d2

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: branch is feature/7879_remove_iteratorToArray

Not a lot to test really, just look at the changes and don't test this before Friday so that we can be sure that it hasn't affected any system tests (assuming they all pass).

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:4 Changed 7 years ago by Martyn Gigg

All of the tests seem unaffected and I agree that this is the type of thing we should be trying to avoid.

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7879_remove_iteratorToArray'

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8724

Note: See TracTickets for help on using tickets.