Improve error handling within ICat

[Jay Rainey]

In a previous ticket (#4674) Russel noted:

N.B. On choosing several of the options from the Catalog menu I see messages like the following on the console:

Object::connect: No such slot ApplicationWindow::writeErrorToLogWindow(const QString&)
Object::connect:  (sender name:   'ICatSearch'

[Jay Rainey]

Upon investigation there appears to be no implementation of writeErrorToLogWindow in ApplicationWindow.cpp. The implementation of error logging was changed ​5 months ago by Martyn in #6202.

The error that is contained in the QString (obtained from ICatUtils.cpp) is extremely similar to an error logged by the related algorithm. Both are runtime exceptions and output:

• ICatUtils.cpp: Please Login to the information catalog using the login menu provided to do the investigation search.
• CatalogMyDataSearch.cpp: Please login to the information catalog using the login dialog provided.

It's therefore worthwhile deciding where we think is best for the error logging to occur. During the attempted execution of the algorithm, or within the algorithm itself.

[Jay Rainey]

This has been addressed in #7866. To verify this is true open ICAT search and no writeErrorToLogWindow errors should occur.

[Nick Draper]

Everything is already merged in #7866

[Stuart Campbell]

This ticket has been transferred to github issue ​8731