Ticket #7888 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Expose ability to set/get EFixed to python

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 3.0
Component: Python Keywords: VISION
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

It would be useful to be able to get/set the EFixed value from Python. We can already set the Efixed (Ei) for direct geometry as this is just a log. We need a way of setting it for indirect geometry instruments that store the value in the ParameterMap.

Change History

comment:1 Changed 7 years ago by Stuart Campbell

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Stuart Campbell

Branch name is feature/7888_expose_efixed_python

comment:3 Changed 7 years ago by Stuart Campbell

Add setEFixed() method. refs #7888

Changeset: a3529176d0948f8fad1ebc3bc1dfdc17570d9847

comment:4 Changed 7 years ago by Stuart Campbell

Expose methods to python.

exposed getEMode(), getEFixed() and setEFixed()

refs #7888

Changeset: f47eeef9b114584655454af2847e74195ce61975

comment:5 Changed 7 years ago by Stuart Campbell

Added test for getEMode(). refs #7888

Changeset: 60bc73feb812e9520b482cd16e98e0538c5d2d15

comment:6 Changed 7 years ago by Stuart Campbell

To Test:

The easiest way is to load a data file from an indirect instrument (e.g. BSS_11841_event.nxs in the AutoTestData directory). Then get the EFixed for a detector, change it, then get it again to make sure it was changed. So something like:

w1=Load("BSS_11841_event.nxs")
print w1.getEFixed(19)
w1.setEFixed(19, 6.666)
print w1.getEFixed(19)

Note: there is nothing special about the detector 19 or 6.666 meV values that are used above.

comment:7 Changed 7 years ago by Stuart Campbell

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:9 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7888_expose_efixed_python'

comment:10 Changed 7 years ago by Andrei Savici

I've tested that the change is picked up by ConvertToMD, in the preprocessed detectors workspace

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8733

Note: See TracTickets for help on using tickets.