Ticket #7893 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveGSASInstrumentFile should obtain constants from .irf file

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: petersonpf@…, huqa@… Blocked By:
Blocking: Tester: Peter Peterson

Description

  1. reading TOF min and TOF max from the IRF file. Looks like you are doing TOF max but not min.
  1. default center wavelength (CWL) is being assumed which of course is incorrect, when we do decide to change the CWL like this cycle. That information is available in the IRF file.
  1. D space min and max has to be calculated properly . Easiest way to do this from the given information is use the TOF min and max and convert to first approximation what d min and d max should be; based on Dtt1!

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

Include CWL to output. Refs #7893.

Changeset: cf9a66c36cfb4df072496d9d82d9468424fdaeda

comment:2 Changed 7 years ago by Wenduo Zhou

Generate tof/dsp range from .irf. Refs #7893.

Changeset: 859887d37bb6bd64dedd87d1cdbe2b044410887a

comment:3 Changed 7 years ago by Wenduo Zhou

Fixed broken unit test. Refs #7893.

Changeset: 3b80f0477b63c28141fbe80d7924536068d531f6

comment:4 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:6 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/7893_read_const_from_irf'

comment:7 Changed 7 years ago by Peter Peterson

Verified that the numbers in the header of the output prm file match the numbers in the irf files (except the oddity in how tof-min is slightly different between the two for real reasons).

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8738

Note: See TracTickets for help on using tickets.