Ticket #7912 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Drag between Script Window ability

Reported by: Owen Arnold Owned by: Nick Draper
Priority: major Milestone: Release 3.1
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

This issue was a suggestion by Emanuel. Reassign as appropriate after checking the validity of this issue.

Should be able to drag a workspace directly out of the workspace list and into the script window.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to inprogress

So for the script window

  1. workspaces -> import statement
  2. file -> load if text
  3. text -> paste

comment:3 Changed 7 years ago by Nick Draper

re #7912 drag and drop of workspaces

Changeset: 6b37df86f45a7cf31a541c5427495427b084e660

comment:4 Changed 7 years ago by Nick Draper

re #7912 drag and drop of files

Changeset: 66208594aa2224d60df7def1900b15d45ef799c3

comment:5 Changed 7 years ago by Nick Draper

re #7912 add a return

Changeset: e38851915368956dcf83934f39f5a07ef1f4f543

comment:6 Changed 7 years ago by Nick Draper

To test:

  1. try draging various things onto the script window (not the interpreter), include text, py files, workspaces from the workspace toolbox
  2. images, none py files should not work
  3. try mixtures of files

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This works fine on Windows.

Linux:

OS X:

  • Python scripts aren't recognized
  • Workspaces come out as: Workspace::workspace_name instead of workspace_name = mtd['workspace_name']

comment:10 Changed 7 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #7912 added some logging

Changeset: 6a4fa9c9d0e6c1208a9648668cb9b85b8c2aa129

comment:11 Changed 7 years ago by Owen Arnold

I've tried this out on OSX 10.8 and it is working fine for me. Everything apart from *.py files may be dragged onto the scripting window. Python files dragged onto the scripting window execute as one would expect. Even handles the case that I load the file, delete the original and then save as one would expect.

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

put in for retest

comment:13 Changed 7 years ago by Martyn Gigg

Don't accept events that have URLs in ScriptEditor drag/drop.

Refs #7912

Changeset: e29086eb7de169790c58453f6e1486622a224dbd

comment:14 Changed 7 years ago by Martyn Gigg

This now seems to work on Ubuntu with the fix in comment 13

comment:15 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:16 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7912_dragdrop_script_window'

Full changeset: 95c33cb360d06ce7d491d9638c86a00bd085aaba

comment:17 Changed 7 years ago by Michael Reuter

This is now working on Linux and OS X.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8757

Note: See TracTickets for help on using tickets.