Ticket #7932 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Removed unneeded code in MdViewerWidget::checkForUpdates

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: minor Milestone: Release 3.1
Component: GUI Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

In doing #7931, I found some unneeded and dead code in MdViewerWidget::checkForUpdates in the MDEWRebinningCutter section. Remove it.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Keywords Maintenance added
  • Milestone changed from Release 3.0 to Release 3.1

comment:2 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:3 Changed 7 years ago by Michael Reuter

Refs #7932. Removing unneeded code.

Changeset: 0485aec956e107a5832d4ef48ac02ee05f0921e0

comment:4 Changed 7 years ago by Michael Reuter

Refs #7932. Resolving conflict.

Changeset: 1c419e9eb25967a1338be4bf4a94d0e7690fff1b

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: You can look at the rather unimpressive diff, but one should also check that the rebinner within the VSI still functions in the expected manner.

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:7 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7932_mdviewer_deadcode'

Full changeset: ​7a6bc3cf0fead2ab049823e2a6ced1cbbf27bf35

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8777

Note: See TracTickets for help on using tickets.