Ticket #7933 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Adjust time step handling for rebinner in VSI

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.1
Component: GUI Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

In doing #7931, I found that the timestep values are being updated by ParaView correctly when using the rebinner. This means that physically setting the animation controls for the timestep values no longer seems to be necessary. However, the enabling and disabling of the animation controls should be retained.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Keywords Maintenance added
  • Milestone changed from Release 3.0 to Release 3.1

comment:2 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

Refs #7933. Removing code for getting time steps.

Leaving behind the code to handle updating the status of the animation controls.

Changeset: edb0ac22566888d46640363d0ad2322d5d1be6bb

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found here.

To test: You need to use a 3D and 4D MDWorkspaces to check and see that the time step handling is still working. Make sure a 3D workspace doesn't allow the animation controls to be enabled. Use a rebinner on the 4D dataset to see that the number of time steps get updated as the rebinning parameters change. Integrate a direction on the 4D to get a 3D and ensure the animation controls get disabled. Reverse the process to enable them again.

comment:4 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7933_vsi_timestep_handling'

Full changeset: 2564eb37e43b681f7fd225579cce4fdd46d60147

comment:6 Changed 7 years ago by Andrei Savici

Checked 3D MD workspace from topaz, 4D from hyspec, with data in systemtests. Works as described

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8778

Note: See TracTickets for help on using tickets.