Muon: Dead Time file logic is broken

[Arturs Bekasovs]

To reproduce:

1. Initially, set Dead Time Table to "None".
2. Load and plot attached EMU00036854.nxs.
3. Now set Dead Time Table to "From Disk", write some nonsense inside the box, e.g. "non-existent file", and press Enter. Message box saying "A problem occurred while applying dead times." should appear, which is expected.
4. Now, click "Browse" near the Dead Time file box, and select attached dtepar.nxs. The same message box appears again. This shouldn't happen, because this IS a valid Dead Time file.
5. Try to select the same file again. This time correction is applied without any errors.
6. Write some non-sense and press Enter again - the correction is applied without errors, though the file obviously does not exist.

[Arturs Bekasovs]

Dead Time Table file

[Arturs Bekasovs]

Sample data file

[Arturs Bekasovs]

(In #6691) While investigating this one, found that the whole Dead Time file thing is not working properly. Ticket for that: #7955.

While it's theoretically possible to implement this one, it would be difficult to verify it before the logic is fixed, so doing that first.

[Arturs Bekasovs]

It seems that the last file found is used instead of the current one loaded.

[Arturs Bekasovs]

(In #6691) Trac issues. Returning blocked by ticket.

[Arturs Bekasovs]

Make loading function throw exceptions, not show messages.

Refs #7955

Changeset: 012befb350cbeca8e0aa1b82aecff01c6badcea5

[Arturs Bekasovs]

Do updates only when Dead Timt Table files where found.

Refs #7955

Changeset: cce6e036148d29a58577d5800b13272b55546b7f

[Arturs Bekasovs]

Move error reporting code to one place.

Plus make error message explicit about the fact that no dead time correction was applied.

Refs #7955

Changeset: 2d36de452f39fbb69e287b113b16ae633270b998

[Arturs Bekasovs]

Check if Dead Time file is valid before using it.

Refs #7955

Changeset: 33a6a7ef3a5f8ab30ea48b9c6d635a244993a5b2

[Arturs Bekasovs]

Tester:

Make sure that the problem in the description is not reproducible any more.

And, in general, check that the logic is correct.

• If Dead Time table file is not valid -> error is shown saying that Dead Time corr. was not applied
• If is valid -> Dead Time correction is applied

[Gesner Passos]

It corrected the problem.

A small issue is that the user is able to interact with the system even with the red mark saying that the deadtime is invalid. And he may go on doing lot's of stuffs, and it does not alert him always that it is not applying the correction. But it is correctly implemented. So, it has passed.

[Gesner Passos]

Merge remote-tracking branch 'origin/bugfix/7955_muon_deadtime_file_logic'

[Stuart Campbell]

This ticket has been transferred to github issue ​8800