Ticket #7964 (closed: fixed)
Better validation for DataSelector file input
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #5421 | Tester: | Nick Draper |
Description (last modified by Samuel Jackson) (diff)
The DataSelector widget should return an empty file name when getCurrentDataName() is called and there is not a valid file. Instead it will give you whatever text is in the box, regardless of if the file is valid.
To reproduce:
- Go to the IDA interface and select Fury.
- Open a file that is not in one of your managed directories as the input file
- Delete the path but keep the name
- Attempt to run fury. The file is not found, but the program still thinks it has a file name to use.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #7964 Updated DataSelector to fix file validation bug.
Also updated fury to properly validate the form.
Changeset: 8fc7919b844537bb0637c6683eab31b870c1e615
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester
- Run the steps listed in the description using any valid input to Fury. You should now be presented with an error message telling you to correct the input of the file browser.
- Also check that the same is true when passing input from an empty workspace selector.
- Do a code inspection and check that the changes are reasonable.
comment:4 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:5 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
There doesn't seem to be branch for this. The change looks like it was done straight on develop, which you shouldn't do. Please make one.
comment:6 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
Forgot to do a git publish on the local branch. 7964 should be a branch on github now.
comment:7 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester changed from Michael Reuter to Nick Draper
comment:9 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/7964_better_dataselector_validation'
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8809