Ticket #7967 (closed: fixed)
Use Locations tag to define all tube types in Merlin IDF
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | maintenance |
| Cc: | anders.markvardsen@… | Blocked By: | |
| Blocking: | Tester: | Martyn Gigg |
Description
The Merlin IDF already uses the locations tag of one tube type, but still uses location tag for another tube type, which is consequently much longer. Ensure all tube types use the locations tag to make them compact.
Change History
comment:4 Changed 7 years ago by Karl Palmen
The IDF with the locations tag for one tube type did not make it to release, but I have a copy available and I'll take the tube definition (and nothing else) from there.
comment:5 Changed 7 years ago by Karl Palmen
Modify MERLIN_Definition.xml to use locations tag for tubes re #7967
This shortens the definition file considerably, but does increase loading time.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: dd393761f51538560573b77951fdfede09ed8fa8
comment:6 Changed 7 years ago by Karl Palmen
To test, save a copy of the MERLIN_definition.xml file from the mantid instrument folder to one of your own folders (not a Mantid default folder) before running the git macros.
Then having run git test start, check that the tube definitions in the instrument file has been shortened by means of the locations tag. Check that both the new and old definition files load and the instrument has identical appearrence in both.
You may then load some MERLIN data files to check they are OK.
comment:7 Changed 7 years ago by Karl Palmen
Correct pixel type for 2nd type of tube re #7967
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 464eb5bcbe36c3a60192fedf21bacffbe47d427f
comment:8 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:9 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:10 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Checked the random detectors in the detector list & the values look the same.
The system tests are also okay so that must mean the positions are correct to within an acceptable precision.
comment:11 Changed 7 years ago by Martyn Gigg
Merge remote-tracking branch 'origin/feature/7967_merlin_locations_tag'
Full changeset: 7194dbfdef8014991b89bb98b7bed420bf8f2b7f
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8812
