Ticket #7972 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

New CopyLogs Algorithm

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

An algorithm to copy the logs stored with a workspace to another workspace would be useful addition to our collection.

This algorithm should include an option to specify what type of merge strategy should be taken. The three types should be the following:

  • WipeExisting: Dump whatever logs are in the other workspace and replace them with the logs from the workspace.
  • MergeKeepExisting: Keep the existing logs and don't modify them, but append the new ones.
  • MergeReplaceExisting: Default option. Replace the values stored in the logs in the workspace being written too, append any new logs, and keep any existing logs which aren't being copied.

Attachments

test_script.py​ (733 bytes) - added by Samuel Jackson 7 years ago.
python script for testing
test_copy_logs.py​ (2.3 KB) - added by Karl Palmen 7 years ago.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #7972 Added new CopyLogs algorithm.

Changeset: 11910b05983fbc6d3bd6cacf54681a3802623003

comment:2 Changed 7 years ago by Samuel Jackson

Refs #7972 Corrected issues with CopyLogs and added unit tests

Changeset: edff621f8983828bb8b8984046b257da109d9b7e

comment:3 Changed 7 years ago by Samuel Jackson

Refs #7972 Updated wiki doc.

Changeset: 944bdee673c12b210ddef080b6bd018bfb58681d

comment:4 Changed 7 years ago by Samuel Jackson

Merge branch 'feature/7972_copy_logs_alg' into develop

Refs #7972

Conflicts:

Code/Mantid/Framework/Algorithms/CMakeLists.txt

Changeset: 657def5c8daf2d29f7b5a52cb690b88c099b4249

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Changed 7 years ago by Samuel Jackson

python script for testing

comment:6 Changed 7 years ago by Samuel Jackson

To Tester

Check that each of the three modes works as described in the ticket info. I've added a python script to demonstrate the functionality and make it easy to play with the new algorithm.

comment:7 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.0

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

Changed 7 years ago by Karl Palmen

comment:9 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Algorithm has performed as expected using the python file I attached.

I was unable to pass the test because of problems with merging the CMakeLists.txt file arising from someone changing the order of two of the files listed.

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #7972 Merge Master into branch to resolve conflict.

Changeset: a4a60c38ccf80297d8c11b9eac6b430c7ca3b760

comment:11 Changed 7 years ago by Samuel Jackson

Merge remote-tracking branch 'origin/master' into feature/7972_copy_logs_alg

Conflicts:

Code/Mantid/Framework/Algorithms/CMakeLists.txt

Refs #7972

Changeset: 065716284ffdb9484b62f7e9ffb5c035a7f11975

comment:12 Changed 7 years ago by Samuel Jackson

Merge branch 'feature/7972_copy_logs_alg' into develop

Conflicts:

Code/Mantid/Framework/Algorithms/CMakeLists.txt

Refs #7972

Changeset: f1e93f26ebba5643dbffc6c27dc0772346081853

comment:13 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Conflict should now be resolved.

comment:14 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Karl Palmen to Andrei Savici

comment:15 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

If I choose merge keep existing, I expected to concatenate logs, so for example if I ramp the temperature in workspace w1 from 1 to 5 and in workspace w2 from 5 to 10, I expected in the end to have a temperature ramp from 1 to 10. If that is not the case, wiki section needs to explicitly say what it does

comment:16 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #7972 Updated wiki doc for algorithm.

Changeset: bce69ba758d14d690728fc30708bd6b611e529b4

comment:17 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is not the case. The algorithm will simply append any logs not in the second workspace and makes no attempt to concatenate logs. I updated the wiki documentation to try and make this more clear.

comment:18 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester changed from Andrei Savici to Owen Arnold

comment:19 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8817

Note: See TracTickets for help on using tickets.